Add source map tests #78
Conversation
The fixtures now provide a sourceFile property which can be used to get the source location.
It can't be used to test source map support if the source maps are already applied to the coverage report. With this change no reports are written to disk. Therefore the temp directory doesn't have to be cleaned.
|
@novemberborn one other annoying thing worth keeping in mind, I started doing a bunch of Windows testing on the weekend and, with the source-map fixtures, we run into issues with
Now, our core functionality does almost work on Windows without |
|
Generate coverage reports for files without source maps or with multiple sources. Refactor source map tests a bit now that three covered fixtures are loaded.
novemberborn
force-pushed
the
source-map-tests
branch
from
27c72c4
to
2a20a22
Compare
|
@novemberborn the generated |
|
If you ever get adventurous, this is what I use for Windows Node testing, it's free and works pretty well on OSX: |
Ah yes it would. Maybe you could track progress in an issue and we can hash stuff out there? Can we use Travis to test Node on Windows? |
|
This is passing CI now. |
|
@novemberborn AppVeyor seems to be the best available: https://ci.appveyor.com/project/bcoe/yargs Let's move Windows chatting to a separate ticket, there's enough problems with Windows right now that it shouldn't block this branch 👍 |
|
|
Tests
_rewritePath()as requested by @bcoe in #66.I'd like to add a test for reading a source map file but I'm not quite sure where to put it. I mean I can test the
add()method I suppose but there's no real test even verifying it's called. @bcoe any ideas? Happy with the coverage we have now?This bumps
source-map-fixtures. I've added asourceFilepath which can be used to create themappedPathfrom #76.I realized the generated coverage report already applied source maps. It now writes the raw coverage file instead.
I've added a few more fixtures (with coverage) to test
_rewritePath().